gwm17/SPS_SABRE_EventBuilder
1
0
Fork 0
mirror of https://github.com/sesps/SPS_SABRE_EventBuilder.git synced 2024-05-19 15:03:19 -04:00
Code Issues Projects Releases Wiki Activity

Compare commits

base: gwm17:51d97d175595ad364bdbf8b1a3b53d88a9a45178
Branches Tags
gwm17:main
gwm17:devel
gwm17:compass_ver1.x
...
compare: gwm17:ca0a7066dfadbfae0ffdf735e8bbf24e5df27557
Branches Tags
gwm17:devel
gwm17:main
gwm17:compass_ver1.x

7 Commits
51d97d1755 ... ca0a7066df

Author SHA1 Message Date
Gordon McCann ca0a7066df
Merge pull request #8 from sesps/main 
Send bug fixes to devel
 2023-05-17 16:40:43 -04:00
Gordon McCann 45763dce66 Fix typo in plotter, resolve #7 2023-05-17 16:37:11 -04:00
Gordon McCann e9c50331f7 Fix typo in analyzed file collection 2023-01-16 11:58:19 -05:00
Gordon McCann a264eea63c Fix bug with merging where TChain::Merge implicitly took ownership of TFile and auto close and deleted 2023-01-16 11:32:00 -05:00
Gordon McCann 4886c497a3 Fix bug where merged dir was not set 2023-01-16 10:30:02 -05:00
Gordon McCann c4557c2b26 Fix bug in CompassFile where m_nHits is uninitialized for CoMPASS empty (2byte) files 2023-01-14 13:16:31 -05:00
Gordon McCann ccd31cda52
Merge pull request #4 from sesps/devel 
Merge devel. Add better workspace handling, some minor API refactor
 2022-10-24 14:35:05 -04:00
3 changed files with 17 additions and 3 deletions
Show Stats Expand all files Collapse all files

1
src/evb/CompassFile.cpp
View File

@ -42,6 +42,7 @@ namespace EventBuilder {
m_eofFlag = false;
m_hitUsedFlag = true;
m_filename = filename;
m_nHits = 0;
m_file->open(m_filename, std::ios::binary | std::ios::in);
m_file->seekg(0, std::ios_base::end);
m_size = m_file->tellg();

17
src/evb/EVBWorkspace.cpp
View File

@ -58,6 +58,7 @@ namespace EventBuilder {
m_analyzedDir = m_workspace + "analyzed/";
m_histogramDir = m_workspace + "histograms/";
m_cutDir = m_workspace + "cuts/";
m_mergedDir = m_workspace + "merged/";
//Check all subdirectories. Terminate if any of them are bad
m_isValid = CheckSubDirectory(m_binaryDir);
@ -79,6 +80,9 @@ namespace EventBuilder {
if(!m_isValid)
return;
m_isValid = CheckSubDirectory(m_cutDir);
if(!m_isValid)
return;
m_isValid = CheckSubDirectory(m_mergedDir);
}
std::string EVBWorkspace::GetBinaryRun(int run)
@ -126,9 +130,11 @@ namespace EventBuilder {
std::vector<std::string> list;
std::string temp;
for(int run=runMin; run<=runMax; run++)
{
temp = GetAnalyzedRun(run);
if(!temp.empty())
list.push_back(temp);
}
return list;
}
@ -187,7 +193,7 @@ namespace EventBuilder {
return false;
TFile* output = TFile::Open(outputname.c_str(), "RECREATE");
if(!output->IsOpen())
if(!output || !output->IsOpen())
{
EVB_ERROR("Could not open output file {0} for merge", outputname);
output->Close();
@ -196,8 +202,15 @@ namespace EventBuilder {
TChain* chain = new TChain("SPSTree", "SPSTree");
for(auto& entry : files)
{
EVB_INFO("Merging file: {0}", entry);
chain->Add(entry.c_str());
chain->Merge(output, 0, "fast");
}
//Note: TChain merge is kinda fucked. It requires a file passed in, which it then implicitly takes ownership of.
//By passing the keep option, we tell TChain we want to keep ownership of the file (otherwise it will automatically close and delete)
//We need ownership because the Merge function does not do a good job of handling errors explicitly.
chain->Merge(output, 0, "fast|keep");
output->Close();
return true;
}

2
src/evb/SFPPlotter.cpp
View File

@ -54,7 +54,7 @@ namespace EventBuilder {
/*Makes histograms where only rejection is unset data*/
void SFPPlotter::MakeUncutHistograms(const ProcessedEvent& ev, THashTable* table)
{
MyFill(table,"x1NoCuts_bothplanes",600,-300,300,ev.x2);
MyFill(table,"x1NoCuts_bothplanes",600,-300,300,ev.x1);
MyFill(table,"x2NoCuts_bothplanes",600,-300,300,ev.x2);
MyFill(table,"xavgNoCuts_bothplanes",600,-300,300,ev.xavg);
MyFill(table,"xavgNoCuts_theta_bothplanes",600,-300,300,ev.xavg,100,0,TMath::Pi()/2.,ev.theta);