From d9466050d9f61699f3ecba5ab2ca8a0a774dff53 Mon Sep 17 00:00:00 2001 From: meditator Date: Sat, 13 Oct 2018 01:54:50 -0400 Subject: [PATCH] X11: Fix missing check for NET_WM_STATE Closes #1356. --- README.md | 1 + src/x11_window.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/README.md b/README.md index 33b031a8..f77f7b42 100644 --- a/README.md +++ b/README.md @@ -239,6 +239,7 @@ information on what to include when reporting a bug. - [X11] Bugfix: Selection I/O reported but did not support `COMPOUND_TEXT` - [X11] Bugfix: Latin-1 text read from selections was not converted to UTF-8 - [X11] Bugfix: NVidia EGL would segfault if unloaded before closing the display +- [X11] Bugfix: Checking window maximized attrib could crash some WMs (#1356) - [Linux] Added workaround for missing `SYN_DROPPED` in pre-2.6.39 kernel headers (#1196) - [Linux] Moved to evdev for joystick input (#906,#1005) diff --git a/src/x11_window.c b/src/x11_window.c index c01cf17e..0ae3b4c8 100644 --- a/src/x11_window.c +++ b/src/x11_window.c @@ -2450,6 +2450,14 @@ int _glfwPlatformWindowMaximized(_GLFWwindow* window) Atom* states; unsigned long i; GLFWbool maximized = GLFW_FALSE; + + if (!_glfw.x11.NET_WM_STATE || + !_glfw.x11.NET_WM_STATE_MAXIMIZED_VERT || + !_glfw.x11.NET_WM_STATE_MAXIMIZED_HORZ) + { + return maximized; + } + const unsigned long count = _glfwGetWindowPropertyX11(window->x11.handle, _glfw.x11.NET_WM_STATE,