From 96412c79fee1e41fb41f1bfdbb96eb87ca8534ea Mon Sep 17 00:00:00 2001 From: Gordon McCann Date: Tue, 20 Jun 2023 12:54:22 -0400 Subject: [PATCH] Remove even more sprintf with snprintf --- .vscode/c_cpp_properties.json | 19 +++++++++++++++++++ implot_items.cpp | 4 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 .vscode/c_cpp_properties.json diff --git a/.vscode/c_cpp_properties.json b/.vscode/c_cpp_properties.json new file mode 100644 index 0000000..6fc0033 --- /dev/null +++ b/.vscode/c_cpp_properties.json @@ -0,0 +1,19 @@ +{ + "configurations": [ + { + "name": "Mac", + "includePath": [ + "${workspaceFolder}/**", + "${workspaceFolder}/../Specter/Specter/vendor/**" + ], + "defines": [], + "macFrameworkPath": [ + "/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks" + ], + "compilerPath": "/usr/bin/clang", + "intelliSenseMode": "macos-clang-x64", + "cppStandard": "c++20" + } + ], + "version": 4 +} \ No newline at end of file diff --git a/implot_items.cpp b/implot_items.cpp index f0cb493..4e398a2 100644 --- a/implot_items.cpp +++ b/implot_items.cpp @@ -1815,7 +1815,7 @@ void PlotPieChart(const char* const label_ids[], const T* values, int count, dou double percent = normalize ? (double)values[i] / sum : (double)values[i]; a1 = a0 + 2 * IM_PI * percent; if (item->Show) { - sprintf(buffer, fmt, (double)values[i]); + snprintf(buffer, sizeof(buffer), fmt, (double)values[i]); ImVec2 size = ImGui::CalcTextSize(buffer); double angle = a0 + (a1 - a0) * 0.5; ImVec2 pos = PlotToPixels(center.x + 0.5 * radius * cos(angle), center.y + 0.5 * radius * sin(angle),IMPLOT_AUTO,IMPLOT_AUTO); @@ -1978,7 +1978,7 @@ void RenderHeatmap(Transformer transformer, ImDrawList& DrawList, const T* value p.y = yref + ydir * (0.5*h + r*h); ImVec2 px = transformer(p); char buff[32]; - sprintf(buff, fmt, values[i]); + snprintf(buff, sizeof(buff), fmt, values[i]); ImVec2 size = ImGui::CalcTextSize(buff); double t = ImClamp(ImRemap01((double)values[i], scale_min, scale_max),0.0,1.0); ImVec4 color = SampleColormap((float)t);